This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-22191: Fix the mentions that get attached in a list #4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we converted our lists to table cells the whitespace nodes behaves differently for Firefox and Webkit so wrapping them in the same span, fixes the problem.
|
@ethervoid Do you know which PR caused this? Does this affect other things than autolinks? |
Willyfrog
approved these changes
Feb 7, 2020
|
/update-branch |
|
@hmhealey a gentle ping :D |
devinbinnie
approved these changes
Feb 10, 2020
|
@devinbinnie Thank you! :) |
|
@lindy65 Sorry I've merged it before QA 🤦♂️ I'll wait to merge the cherry pick until I have the ok from you :_( |
|
OK, thanks @ethervoid - testing now 👍 |
|
Test server creation failed. See the logs for more information. |
|
Thanks @ethervoid - tested on the cherry-pick spinwick and this is fixed 👍 |
ethervoid
pushed a commit
that referenced
this pull request
Feb 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we converted our lists to table cells the whitespace nodes
behaves differently for Firefox and Webkit so wrapping them in the
same span, fixes the problem.
Thank you @hmhealey for your help
Summary
This PR fixes a problem introduced when we make the list elements a table. After that, the whitespace nodes kept working in Firefox but in Webkit didn't.
Looks like the mix between tables and li elements causes this problem and wrapping the content of the li element into a span fixes it.
Ticket Link
https://mattermost.atlassian.net/browse/MM-22192