This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
PLT-8358 Properly show error bar after trying to edit a post after the allowed time #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
approved these changes
Dec 15, 2017
crspeller
approved these changes
Dec 15, 2017
hmhealey
changed the title
hmhealey
added
4: Reviews Complete
jasonblais
added
Changelog/Not Needed
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error bar for the edit post modal was no longer being displayed because the error it was trying to display didn't have a type.
I also fixed some related issues that Eric and I found where the modal would close randomly after the time period had past. This was due to some code that looked intentional as well as a selector that wasn't working correctly.
Ticket Link
https://mattermost.atlassian.net/browse/PLT-8358