Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

PLT-8335 Fixing issue where posts do not send on iOS classic #476

Merged
merged 3 commits into from
Dec 14, 2017
Merged

PLT-8335 Fixing issue where posts do not send on iOS classic #476

merged 3 commits into from
Dec 14, 2017

Conversation

coreyhulen
Copy link
Contributor

@coreyhulen coreyhulen commented Dec 14, 2017 •
edited
Loading

This requires a PR from the redux repo

@coreyhulen coreyhulen added the 2: Dev Review Requires review by a core commiter label Dec 14, 2017
@coreyhulen coreyhulen added this to the v4.5.0 milestone Dec 14, 2017
enahum
enahum approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wondering if we want to make the webapp to always use this new action instead of checking the userAgent

@coreyhulen
Copy link
Contributor Author

0/5 on switching and only using the one. I don't know enough about how they work to give a confident answer.

@crspeller crspeller merged commit 5e5a1e6 into release-4.5 Dec 14, 2017
@crspeller crspeller deleted the PLT-8335 branch December 14, 2017 23:28
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Dec 15, 2017
@jasonblais jasonblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Jan 4, 2018
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@mkraft
MM-10344 & MM-10345: Adds actions to update team and channel scheme. (#…
eecce9e 
…476)

* MM-10344 & MM-10345: Adds actions to update team and channel scheme.

* MM-10344: Changes indentation.

* MM-10344 & MM-10345: Refactored the actions.

* MM-10344: Combines 2 const declaration lines into 1.

* MM-10344: Test fix.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@enahum enahum enahum approved these changes

@jwilander jwilander Awaiting requested review from jwilander

Assignees

@crspeller crspeller

Labels
2: Dev Review Requires review by a core commiter Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v4.5.0
5 participants
@coreyhulen @enahum @crspeller @jasonblais @lindalumitchell