This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-21876 Fix toast not showing up on marking channel as unread again #4737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use lastViewedAt on client to determine if channel is marked
as unread again
sudheerDev
added
2: Dev Review
|
There is one case this PR still does not solve. i.e marking the same message as unread. IMO we should leave it as a known issue as solving it means tracking some unnecessary changes we most likely ever use. |
|
@sudheerDev what do you think the mana would be to fix this issue? |
amyblais
added
the
CherryPick/Approved
deanwhillier
approved these changes
Jan 24, 2020
Willyfrog
approved these changes
Jan 27, 2020
jgilliam17
added
the
Setup Cloud Test Server
jgilliam17
approved these changes
Jan 29, 2020
jgilliam17
added
QA Review Done
and removed
3: QA Review
|
Test server destroyed |
|
/update-branch |
Talked with ES on this. We are going to leave this as known issue for now. It is not hard < 8 Mana but the code will always be hacky and it will be specifically for this corner case. |
mattermod
added
the
CherryPick/Done
mattermod
removed
the
CherryPick/Approved
sudheerDev
added a commit
that referenced
this pull request
Jan 29, 2020
* MM-21876 Fix toast not showing up on marking channel as unread again * Use lastViewedAt on client to determine if channel is marked as unread again * Update tests * Lint fix Co-authored-by: Sudheer <[email protected]>
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
https://mattermost.atlassian.net/browse/MM-21876
Known issue: Toast wont show up if the same message is marked as unread. This case is hard to solve as it is. We could consider keeping a counter for keeping tracking for this i.e something of the sorts 2times marked as unread etc but otherwise this is hard to do with redux state.