This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Toasts feature on top of 5.19v #4699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [MM-19533] working unread toast * Fix unread count * For channels which have more than 30 posts * Add toast for channel marked as read * Update atBottom logic * Dont show tooltip if action cannot be taken * Update remove toast logic to not compare old bottom state * Update redux hash * Update tests * Change new message since i18 string formats * Update react-window hash * Update time to use LocalDateTime * Use lastViewAt instead of lastViewBottom at for showing time in toast
…cript console (#4681) * Add missing bracket that was creating errors on javascript console * Update lastViewedAt expected prop type
|
We can close this PR, the customer doesn't need the build anymore they are waiting until v5.20 |
|
Test server destroyed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for testing toasts feature on top of 5.19v branches