Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-17555 Add dummy OverlayTrigger component #4639

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

hmhealey
Copy link
Member

@hmhealey hmhealey commented Jan 8, 2020

We need to add our own OverlayTrigger as part of the react-intl upgrade. This PR adds the file for our custom OverlayTrigger, but that just points back to the one provided by react-bootstrap for now.

Ticket Link

https://mattermost.atlassian.net/browse/MM-17555

Related Pull Requests

Part of #4615

@hmhealey hmhealey added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jan 8, 2020
@hmhealey hmhealey added this to the v5.20.0 milestone Jan 8, 2020
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino removed the 2: Dev Review Requires review by a core commiter label Jan 9, 2020
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No testing needed.
Approving based on my discussion with Harrison as only one file is moved and references updated.

@jgilliam17 jgilliam17 added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Jan 9, 2020
@hmhealey hmhealey added the 4: Reviews Complete All reviewers have approved the pull request label Jan 9, 2020
@hmhealey hmhealey merged commit dd267d4 into master Jan 9, 2020
@hmhealey hmhealey deleted the mm17555-overlaytrigger branch January 9, 2020 18:15
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
5 participants