This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-17555 Update tests that use string refs #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
devinbinnie
approved these changes
Jan 9, 2020
jgilliam17
approved these changes
Jan 9, 2020
jgilliam17
added
QA Review Done
and removed
3: QA Review
bradjcoughlin
approved these changes
Jan 9, 2020
hmhealey
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests that use string refs will break when react-intl is upgraded, so I modified them slightly to not use the refs.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17555
Related Pull Requests
Part of #4615