Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

PLT-8244 Prevented web app from loading before storage is loaded #462

Merged
merged 6 commits into from
Dec 14, 2017

Conversation

hmhealey
Copy link
Member

Because previously storage wasn't always loaded when the app started it would cause two things:

  1. The post draft for the current channel wouldn't usually be loaded
  2. The previous team/channel wouldn't be loaded if you didn't explicitly navigate to them

This prevents the app from loading until the storage is loaded. Ideally, we would lock the individual parts, but because the routing code controls the current team/channel, we needed to prevent even that from running.

Ticket Link

https://mattermost.atlassian.net/browse/PLT-8244

Checklist

  • Added or updated unit tests (required for all new features)
  • Touches critical sections of the codebase (auth, posting, etc.)

@hmhealey hmhealey added the 2: Dev Review Requires review by a core commiter label Dec 13, 2017
@hmhealey hmhealey added this to the v4.5.0 milestone Dec 13, 2017
@hmhealey
Copy link
Member Author

@jespino It might be helpful if you looked over this, if you have a chance

Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we do this in RN and it makes total sense...

FYI: build is failing

@jespino
Copy link
Member

jespino commented Dec 14, 2017

I going to try it in my computer, and check a pair os things (the localForage generated keys, the sync between tabs, etcetera).

@jespino
Copy link
Member

jespino commented Dec 14, 2017

Looks like everything is working as expected in the storage part (I was concerned about the store/restore/sync-between-tabs processes, but looks like everything is working fine) :)

@crspeller crspeller merged commit 4976240 into release-4.5 Dec 14, 2017
@crspeller crspeller deleted the plt8244 branch December 14, 2017 17:48
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Dec 15, 2017
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 4, 2018
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2: Dev Review Requires review by a core commiter Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
6 participants