Fixes #13345 : UI Automation: Write an automated test using Cypress for "Selected options with long usernames are not cut off in the RHS"

[M-ZubairAhmed]

Summary

Test to check if long usernames are truncated in options in rhs

Ticket Link

Fixes : mattermost/mattermost#13345
Jira : https://mattermost.atlassian.net/browse/MM-21038

[M-ZubairAhmed]

This PR is blocked until issue addressed raised here mattermost/mattermost#13345 (comment) is addressed

[saturninoabril]

@M-ZubairAhmed The long username is permissible on server but has limitation on client only. I'd suggest to continue with the original test requirement with my comment on how to create new user with long username.

[M-ZubairAhmed]

This PR is blocked until team discussion for how does long username should look like

[saturninoabril]

https://mattermost.atlassian.net/browse/MM-21467 - ticket filed on expected behavior of truncated and not cut-off.

[mattermod]

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

[M-ZubairAhmed]

Closing this until the issue above is solved

[saturninoabril]

@M-ZubairAhmed fyi, selected long username is now truncated. Fixed by #4671

[M-ZubairAhmed]

oh i am taking about Note: This test requires webhook server running. Initiatenpm run start:webhook to start.

[josephbaylon]

@M-ZubairAhmed When I have the webhook turned on I get this different failure consistently

[josephbaylon]

@saturninoabril Are you able to run this test fine? If so, I'll defer to your results

[M-ZubairAhmed]

@josephbaylon do you mind sharing the complete screen shot ?

[josephbaylon]

@M-ZubairAhmed Here's what I've observed. If I run it by itself, the test passes but if I run it with the other tests in the file, it fails. For some reason, when run with other tests, the webhook post for user options doesn't get posted. I tried adding a timeout but still the same. Maybe you could run the whole test and see if you get the same behavior.

[M-ZubairAhmed]

@josephbaylon oh yes i can see that now, it looks like there is some issue with the webhook. Do you and @saturninoabril know how this can be solved ?

[saturninoabril]

For some reason, all tests passed on me the first time I reviewed this and now seeing the same failing test as yours. I'll take a look.

[M-ZubairAhmed]

thank you @saturninoabril

[saturninoabril]

I'm seeing invalid session log on server. It may be due to cy.createNewUser that sign out then sign in sysadmin. For long term fix, we might need to revisit cy.createNewUser. Short fix for this PR is to move cy.createNewUser at before hook.

...
let longUsername;

describe('Interactive Menu', () => {
    before(() => {
        // Set required ServiceSettings
        const newSettings = {
            ServiceSettings: {
                AllowedUntrustedInternalConnections: 'localhost',
                EnablePostUsernameOverride: true,
                EnablePostIconOverride: true,
            },
        };
        cy.apiUpdateConfig(newSettings);

        cy.apiLogin('sysadmin').visit('/ad-1');
        longUsername = `name-of-64-abcdefghijklmnopqrstuvwxyz-123456789-${Date.now()}`;
        cy.getCurrentTeamId().then((teamId) => {
            // # Create a new user with 64 chars length
            cy.createNewUser({username: longUsername}, [teamId]);
        });

        // # Login as sysadmin and ensure that teammate name display setting is set to default 'username'
        cy.apiLogin('sysadmin');
        ...

[M-ZubairAhmed]

thank you @saturninoabril for swiftly identifying the bug, I will send the update.
In future please refer the issue for the fix to me, i will be happy to help

[M-ZubairAhmed]

Hi, i fixed the test as per Saturnino's comment

[josephbaylon]

LGTM. Works for me now.

[josephbaylon]

@saturninoabril I'm not sure what's happening with the untagged-build failure.. says upload-s3 - Unauthorized Do you know how to resolve this?

[saturninoabril]

If no outstanding issue on CI, we may try updating the branch and see if it passed. Else, we may ask help from Build team.

[saturninoabril]

/update-branch