Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixes #13485 : Migrate 'components/tutorial/tutorial_tip' module and associated tests to TypeScript #4589

Merged
merged 10 commits into from
Jan 6, 2020
Merged

Fixes #13485 : Migrate 'components/tutorial/tutorial_tip' module and associated tests to TypeScript #4589

merged 10 commits into from
Jan 6, 2020

Conversation

M-ZubairAhmed
Copy link
Member

Summary

Migrated file and tests of tutorial tips component

Ticket Link

Fixes : mattermost/mattermost#13485
Jira : https://mattermost.atlassian.net/browse/MM-20587

@hanzei hanzei added the Work in Progress Not yet ready for review label Dec 25, 2019
@M-ZubairAhmed
Copy link
Member Author

@hanzei this PR is complete

@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed Work in Progress Not yet ready for review labels Dec 26, 2019
jespino
jespino approved these changes Dec 26, 2019
View reviewed changes
Copy link
Member

@jespino jespino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @M-ZubairAhmed! 💃

devinbinnie
devinbinnie suggested changes Jan 2, 2020
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @M-ZubairAhmed! Just one small nitpick.

components/tutorial/tutorial_tip/tutorial_tip.test.tsx Outdated Show resolved Hide resolved
devinbinnie
devinbinnie approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @M-ZubairAhmed!

@devinbinnie devinbinnie removed the 2: Dev Review Requires review by a core commiter label Jan 2, 2020
lindy65
lindy65 approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @M-ZubairAhmed 👍

@lindy65 lindy65 added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Jan 6, 2020
@devinbinnie devinbinnie added the 4: Reviews Complete All reviewers have approved the pull request label Jan 6, 2020
@devinbinnie
Copy link
Member

/update-branch

@devinbinnie devinbinnie merged commit bad4409 into mattermost:master Jan 6, 2020
@amyblais amyblais added the Changelog/Not Needed Does not require a changelog entry label Jan 6, 2020
@amyblais amyblais added the Docs/Not Needed Does not require documentation label Jan 6, 2020
@M-ZubairAhmed M-ZubairAhmed deleted the MM-20587 branch January 7, 2020 06:59
@hanzei hanzei added this to the v5.20.0 milestone Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jespino jespino jespino approved these changes

@lindy65 lindy65 lindy65 approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.20.0
8 participants
@M-ZubairAhmed @devinbinnie @jespino @lindy65 @jasonblais @hanzei @amyblais @mattermod