Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-21152: Fix race condition where CurrentTeam is not initialized yet #4544

Merged
merged 2 commits into from
Dec 22, 2019
Merged

MM-21152: Fix race condition where CurrentTeam is not initialized yet #4544

merged 2 commits into from
Dec 22, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Dec 18, 2019

Summary

Sometimes the currentTeam can be not initialized yet on refresh or login, so we need to handle that cases.

Ticket Link

MM-21152

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 18, 2019
@jespino jespino added this to the v5.19.0 milestone Dec 18, 2019
streamer45
streamer45 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

srkgupta
srkgupta approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally and re-ran the failing Cypress tests multiple times and now the issue is no longer seen. Testcase already exists and is automated and hence no need to add/update new testcase. Approving the PR.

@srkgupta srkgupta added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Dec 18, 2019
@jespino
Copy link
Member Author

jespino commented Dec 22, 2019

/update-branch

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Dec 22, 2019
@jespino jespino merged commit bf50b44 into mattermost:master Dec 22, 2019
@jespino jespino deleted the MM-21152 branch December 22, 2019 12:14
@mattermost-build mattermost-build mentioned this pull request Dec 22, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 22, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reflog reflog reflog approved these changes

@srkgupta srkgupta srkgupta approved these changes

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.19.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jespino @reflog @srkgupta @streamer45 @mattermod @amyblais