Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-21197: Hides some groups-related inputs and menu items without the… #4511

Merged
merged 3 commits into from
Dec 13, 2019
Merged

MM-21197: Hides some groups-related inputs and menu items without the… #4511

merged 3 commits into from
Dec 13, 2019

Conversation

mkraft
Copy link
Contributor

@mkraft mkraft commented Dec 12, 2019

… proper license for the LDAPGroups feature.

Summary

Hides some inputs and menu items related to groups that should not be shown if not licensed for LDAPGroups feature.

Ticket Link

https://mattermost.atlassian.net/browse/MM-21197

@mkraft mkraft added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 12, 2019
@mkraft mkraft added this to the v5.18.0 milestone Dec 12, 2019
@wiersgallak wiersgallak added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 12, 2019
@mattermod
Copy link
Contributor

Mattermost test server updated with git commit e38a118675f322066897d5bac2f7e6c42187843b.

Access here: https://mattermost-webapp-pr-4511.test.mattermost.cloud

@hahmadia hahmadia removed the 2: Dev Review Requires review by a core commiter label Dec 12, 2019
@srkgupta srkgupta removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 13, 2019
@mattermod
Copy link
Contributor

Test server destroyed

@srkgupta srkgupta added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 13, 2019
srkgupta
srkgupta approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the PR instance and the Add Groups to Team and Manage Groups options are no longer shown to users when a license is downgraded from E20 to E10. Approving the PR.

@srkgupta srkgupta added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Dec 13, 2019
wiersgallak
wiersgallak approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Marting. LGTM

@wiersgallak wiersgallak added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager labels Dec 13, 2019
@mkraft mkraft merged commit 1834b51 into master Dec 13, 2019
@mkraft mkraft deleted the MM-21197 branch December 13, 2019 14:38
@mattermod
Copy link
Contributor

Test server destroyed

@mattermost-build mattermost-build mentioned this pull request Dec 13, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 13, 2019
mkraft pushed a commit that referenced this pull request Dec 13, 2019
@mattermost-build
Automated cherry pick of #4511 (#4519)
6d67df9 
* MM-21197: Hides some groups-related inputs and menu items without the proper license for the LDAPGroups feature.

* MM-21197: Uses licensedForFeature function.

* MM-21197: Fix.
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 13, 2019
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Dec 14, 2019
@hanzei hanzei removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@hahmadia hahmadia hahmadia approved these changes

@wiersgallak wiersgallak wiersgallak approved these changes

@catalintomai catalintomai catalintomai approved these changes

Assignees

@mkraft mkraft

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.18.0
9 participants
@mkraft @mattermod @srkgupta @hahmadia @wiersgallak @catalintomai @hanzei @lindalumitchell @amyblais