This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fixing JS error on channel leave or being removed from the channel #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
added
2: Dev Review
enahum
approved these changes
Dec 4, 2019
| const curChannel = this.refs[channelId].getWrappedInstance().refs.channel.getBoundingClientRect(); | ||
| if ((curChannel.top - Constants.CHANNEL_SCROLL_ADJUSTMENT < 0) || (curChannel.top + curChannel.height > this.refs.scrollbar.view.getBoundingClientRect().height)) { | ||
| this.refs.scrollbar.scrollTop(this.refs.scrollbar.view.scrollTop + (curChannel.top - Constants.CHANNEL_SCROLL_ADJUSTMENT)); | ||
| if (this.refs[channelId]) { |
There was a problem hiding this comment.
Candidate for a HW campaign, change the refs to the new format
alifarooq0
approved these changes
Dec 4, 2019
stevemudie
approved these changes
Dec 4, 2019
amyblais
added
4: Reviews Complete
mattermod
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing JS error on channel leave or being removed from the channel. If the
channelId was undefined or the channelId is not longer rendered there is no
ref, we need to check that before we try to use the ref.
Ticket Link
MM-20929
MM-20920