Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-19813 - Focusing back the message input box on preview disable #4435

Merged
merged 2 commits into from
Dec 5, 2019
Merged

MM-19813 - Focusing back the message input box on preview disable #4435

merged 2 commits into from
Dec 5, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Dec 4, 2019

Summary

Focusing back the message input box on preview disable

Ticket Link

MM-19813

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 4, 2019
@jespino jespino added this to the v5.20.0 milestone Dec 4, 2019
@stevemudie stevemudie added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 4, 2019
stevemudie
stevemudie approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevemudie stevemudie added QA Review Done Tests/Done Release tests have been written and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Dec 4, 2019
@mattermod
Copy link
Contributor

Test server destroyed

Willyfrog
Willyfrog approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alifarooq0 alifarooq0 changed the title Focusing back the message input box on preview disable MM-19813 - Focusing back the message input box on preview disable Dec 5, 2019
alifarooq0
alifarooq0 approved these changes Dec 5, 2019
View reviewed changes
components/create_comment/create_comment.jsx Outdated Show resolved Hide resolved
@alifarooq0 alifarooq0 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Dec 5, 2019
@jespino jespino merged commit 178ce0d into mattermost:master Dec 5, 2019
@jespino jespino deleted the MM-19813 branch December 5, 2019 18:19
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Willyfrog Willyfrog Willyfrog approved these changes

@stevemudie stevemudie stevemudie approved these changes

@alifarooq0 alifarooq0 alifarooq0 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.20.0
6 participants
@jespino @mattermod @Willyfrog @stevemudie @alifarooq0 @amyblais