Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixing error handling for schema admin settings #4414

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Fixing error handling for schema admin settings #4414

merged 1 commit into from
Dec 3, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Dec 2, 2019

Summary

Fixing error handling for schema admin settings

Ticket Link

MM-20765

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 2, 2019
@jespino jespino added this to the v5.18.0 milestone Dec 2, 2019
@ogi-m ogi-m added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 2, 2019
@sbishel sbishel mentioned this pull request Dec 2, 2019
Closed
sbishel
sbishel approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reflog
reflog approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@reflog reflog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Dec 3, 2019
ogi-m
ogi-m approved these changes Dec 3, 2019
View reviewed changes
Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that an appropriate error message is shown in the UI

@ogi-m ogi-m added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Dec 3, 2019
@mattermod
Copy link
Contributor

Test server destroyed

@jespino jespino added the 4: Reviews Complete All reviewers have approved the pull request label Dec 3, 2019
@jespino jespino merged commit 8b1d273 into mattermost:master Dec 3, 2019
@jespino jespino deleted the MM-20765 branch December 3, 2019 14:51
@mattermost-build mattermost-build mentioned this pull request Dec 3, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 3, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reflog reflog reflog approved these changes

@sbishel sbishel sbishel approved these changes

@ogi-m ogi-m ogi-m approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.18.0
6 participants
@jespino @mattermod @reflog @sbishel @ogi-m @amyblais