Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Remove erroneous parameter for debounce #4408

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Remove erroneous parameter for debounce #4408

merged 2 commits into from
Dec 3, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Dec 2, 2019

Summary

Remove erroneous parameter for debounce (generating missed requests for user searches).

Ticket Link

MM-20701

@jespino jespino added this to the v5.18.0 milestone Dec 2, 2019
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 2, 2019
@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Dec 2, 2019
stevemudie
stevemudie approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA will test once merge is complete

@stevemudie stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Dec 2, 2019
mgdelacroix
mgdelacroix approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Willyfrog
Willyfrog approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Willyfrog Willyfrog added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Dec 3, 2019
@jespino jespino merged commit 91da11a into mattermost:master Dec 3, 2019
@jespino jespino deleted the MM-20701 branch December 3, 2019 16:05
@mattermost-build mattermost-build mentioned this pull request Dec 3, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 3, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 3, 2019
amyblais pushed a commit that referenced this pull request Dec 3, 2019
@mattermost-build @amyblais
Automated cherry pick of #4408 (#4420)
d244431 
* Remove erroneous parameter for debounce

* Fixing system_user tests
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@Willyfrog Willyfrog Willyfrog approved these changes

@stevemudie stevemudie stevemudie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.18.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jespino @mgdelacroix @Willyfrog @stevemudie @mattermod @lindalumitchell @amyblais