Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[GH-13174] UI Automation: Write an automated test using Cypress for "Can change Mattermost Apps Download Page Link setting" #4388

Merged

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Nov 30, 2019

… Download Page Link setting"

Summary

UI Automation: Write an automated test using Cypress for "Can change Mattermost Apps Download Page Link setting"

Ticket Link

Fixes mattermost/mattermost#13174

Related Pull Requests

None

Screenshots

None

@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 1, 2019
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larkox Thanks! LGTM, just need to update and fix merge conflicts.

@saturninoabril saturninoabril added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Dec 2, 2019
Copy link
Contributor

@hahmadia hahmadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@hahmadia hahmadia self-assigned this Dec 3, 2019
@hahmadia
Copy link
Contributor

hahmadia commented Dec 3, 2019

/check-cla

@hahmadia hahmadia added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Dec 3, 2019
@hahmadia
Copy link
Contributor

hahmadia commented Dec 3, 2019

/update-branch

@hahmadia hahmadia added the AutoMerge used by Mattermod to merge PR automatically label Dec 3, 2019
@mattermod
Copy link
Contributor

Will try to auto merge this PR

@mattermod mattermod merged commit c344cc1 into mattermost:master Dec 3, 2019
@mattermod
Copy link
Contributor

Pull Request successfully merged
SHA: c344cc1

@mattermod mattermod removed the AutoMerge used by Mattermod to merge PR automatically label Dec 3, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
7 participants