Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-17555 Remove some unneeded refs #4377

Merged
merged 4 commits into from
Dec 11, 2019
Merged

MM-17555 Remove some unneeded refs #4377

merged 4 commits into from
Dec 11, 2019

Conversation

hmhealey
Copy link
Member

Just some cleanup of unused string refs since those were what caused most of the issues with the last react-intl upgrade. This shouldn't have any functional impact for users.

Ticket Link

https://mattermost.atlassian.net/browse/MM-17555

@hmhealey hmhealey added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 29, 2019
@hmhealey hmhealey added this to the v5.20.0 milestone Nov 29, 2019
@jwilander jwilander removed the 2: Dev Review Requires review by a core commiter label Nov 29, 2019
@hmhealey
Copy link
Member Author

hmhealey commented Dec 3, 2019

/update-branch

@hmhealey
Copy link
Member Author

hmhealey commented Dec 9, 2019

/update-branch

Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my discussion with Harrison, nothing for QA to test as changes didn't have any functional impact.

@jgilliam17 jgilliam17 added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Dec 11, 2019
@hmhealey hmhealey added the 4: Reviews Complete All reviewers have approved the pull request label Dec 11, 2019
@hmhealey hmhealey merged commit 9657efd into master Dec 11, 2019
@hmhealey hmhealey deleted the mm17555b branch December 11, 2019 15:10
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
6 participants