This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-20749: restrict post menu nesting #4372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submenus in the RHS may exceed the width of the RHS, and are currently truncated. While this will happen with any long submenu text, it's especially painful when multiple levels of nesting are allowed. For now, disable more than one submenu nesting level. Fixes: https://mattermost.atlassian.net/browse/MM-20749
alifarooq0
approved these changes
Nov 29, 2019
|
@lieut-data The change here is tiny but would any unit test coverage help? |
prapti
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Tested and verified locally with demo plugin changes in mattermost/mattermost-plugin-demo#78.
Approving.
|
Test server creation failed. See the logs for more information. |
|
/update-branch |
lieut-data
pushed a commit
that referenced
this pull request
Dec 2, 2019
* MM-20749: restrict post menu nesting Submenus in the RHS may exceed the width of the RHS, and are currently truncated. While this will happen with any long submenu text, it's especially painful when multiple levels of nesting are allowed. For now, disable more than one submenu nesting level. Fixes: https://mattermost.atlassian.net/browse/MM-20749 * Update plugins/registry.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Submenus in the RHS may exceed the width of the RHS, and are currently truncated. While this will happen with any long submenu text, it's especially painful when multiple levels of nesting are allowed.
For now, disable more than one submenu nesting level.
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-20749