Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fix failing E2E tests on guest account #4323

Merged
merged 7 commits into from
Nov 27, 2019
Merged

Fix failing E2E tests on guest account #4323

merged 7 commits into from
Nov 27, 2019

Conversation

srkgupta
Copy link
Contributor

Summary

Fixed failing E2E tests on Guest Accounts. When a Member is demoted to Guest, by default guest user
is assigned to default channels. Updated the assertions.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Is this for 5.18? If so, please change milestone accordingly and set label to CherryPick/Approve.

@hanzei hanzei added the 2: Dev Review Requires review by a core commiter label Nov 25, 2019
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 27, 2019
@jespino jespino merged commit d22160a into mattermost:master Nov 27, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request AutomatedCherryPick Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
5 participants