Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixing more channels modal dropdown text color #4316

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Fixing more channels modal dropdown text color #4316

merged 2 commits into from
Nov 29, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Nov 22, 2019

Summary

Fixing more channels modal dropdown text color (now using a css variable for that)

Ticket Link

MM-20623

@hanzei hanzei added the Work in Progress Not yet ready for review label Nov 25, 2019
@amyblais amyblais added this to the v5.18.0 milestone Nov 27, 2019
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed Work in Progress Not yet ready for review labels Nov 28, 2019
@jespino jespino requested review from a team and lindy65 November 28, 2019 09:13
@ghost ghost requested review from jfrerich and mickmister and removed request for a team November 28, 2019 09:13
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 28, 2019
@jespino jespino requested review from mgdelacroix and Willyfrog and removed request for jfrerich and mickmister November 28, 2019 16:32
mgdelacroix
mgdelacroix approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lindy65 lindy65 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 29, 2019
lindy65
lindy65 approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jespino - this is fixed as per ticket testing description.

I am, however, seeing an issue where the bottom of the drop-down is very close to Click 'Create New Channel' to make a new one and the left-hand-side of the drop-down is not left-aligned with the "S" of "Show: Public Channels", so I have created a separate ticket to address the issue.

image

@lindy65 lindy65 added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Nov 29, 2019
@mattermod
Copy link
Contributor

Test server destroyed

Willyfrog
Willyfrog approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, although I find it weird to have a hover modifier keeping the same color, but that is not part of this ticket, so no complain there :D

@Willyfrog Willyfrog added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 29, 2019
@Willyfrog Willyfrog merged commit ebf731f into mattermost:master Nov 29, 2019
@mattermost-build mattermost-build mentioned this pull request Nov 29, 2019
Merged
@mattermod mattermod added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Nov 29, 2019
@mattermod mattermod removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 29, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 29, 2019
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@Willyfrog Willyfrog Willyfrog approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.18.0
8 participants
@jespino @mattermod @mgdelacroix @Willyfrog @lindy65 @hanzei @lindalumitchell @amyblais