This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-20027 - Reporting > Statistics showing 'Loading...' when value is zero #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflog
added
2: Dev Review
reflog
changed the title
ghost
requested review from
cpanato and
stylianosrigas
and removed request for
a team
reflog
changed the title
reflog
changed the title
cpanato
requested review from
jespino and
mkraft
and removed request for
cpanato and
stylianosrigas
lindy65
added
the
Setup Cloud Test Server
jespino
approved these changes
Nov 21, 2019
|
Test server destroyed |
mattermod
added
CherryPick/Done
|
ooops. merged by mistake 😢 |
reflog
added a commit
that referenced
this pull request
Nov 21, 2019
* check for undefined values instead * lint Co-authored-by: Eli Yukelzon <[email protected]>
|
No worries @reflog - we can test post-merge |
lindy65
reviewed
Nov 21, 2019
lindy65
added
Tests/Not Needed
amyblais
added
Changelog/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Statistics widget checked for 'loading/undefined' state by using
!countinstead of actually checking if it's undefinedTicket Link
Fixes https://mattermost.atlassian.net/browse/MM-20027