This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[GH-12281] UI Automation: Write an automated test using Cypress for "Delete a Message during reply, other user sees (message deleted)"
#4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ply, other user sees `(message deleted)`"
saturninoabril
added
2: Dev Review
ghost
removed their request for review
streamer45
approved these changes
Nov 22, 2019
saturninoabril
suggested changes
Nov 26, 2019
There was a problem hiding this comment.
@larkox Sorry for delayed review. Looks good except for one request.
e2e/cypress/integration/messaging/message_deleted_on_reply_spec.js
Outdated
Show resolved
Hide resolved
components/rhs_thread/rhs_thread.jsx
Outdated
| @@ -394,6 +394,7 @@ export default class RhsThread extends React.Component { | |||
| <div | |||
| ref='rhspostlist' | |||
| className='post-right-comments-container' | |||
| id='post-right-comments-container' | |||
There was a problem hiding this comment.
Please use camelCase. Also, I'd suggest ID to be
Suggested change
| id='post-right-comments-container' | |
| id='rhsPostList' |
saturninoabril
added
4: Reviews Complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UI Automation: Write an automated test using Cypress for "Delete a Message during reply, other user sees
(message deleted)"Ticket Link
Fixes mattermost/mattermost#12281
Related Pull Requests
None
Screenshots
None