Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixing styles using css variables and initializing them properly #4256

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Fixing styles using css variables and initializing them properly #4256

merged 2 commits into from
Nov 27, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Nov 18, 2019

Summary

Fixing styles using css variables and initializing them properly

Ticket Link

MM-20008

@jespino jespino requested a review from a team November 18, 2019 18:58
@ghost ghost requested review from devinbinnie and gabrieljackson and removed request for a team November 18, 2019 18:58
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 18, 2019
@jespino jespino added this to the v5.18.0 milestone Nov 18, 2019
@srkgupta srkgupta added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 19, 2019
@mattermod mattermod removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 19, 2019
@mattermod
Copy link
Contributor

Test server destroyed

@srkgupta srkgupta added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 19, 2019
@mattermod mattermod removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 19, 2019
@mattermod
Copy link
Contributor

Test server destroyed

srkgupta
srkgupta approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it works fine. There are no more black text which appears while loading. Approving the PR.

@srkgupta srkgupta added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Nov 19, 2019
gabrieljackson
gabrieljackson approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 22, 2019
@jespino
Copy link
Member Author

jespino commented Nov 27, 2019

/update-branch

@jespino jespino merged commit 6f88c14 into mattermost:master Nov 27, 2019
@jespino jespino deleted the MM-20008 branch November 27, 2019 12:04
@mattermost-build mattermost-build mentioned this pull request Nov 27, 2019
Merged
@mattermod mattermod added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Nov 27, 2019
@mattermod mattermod removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 27, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@gabrieljackson gabrieljackson gabrieljackson approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

@jespino jespino

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.18.0
6 participants
@jespino @mattermod @srkgupta @gabrieljackson @devinbinnie @amyblais