Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[GH-12263] UI Automation: Write an automated test using Cypress for "At-mention user autocomplete does not overlap with channel header when drafting a long message containing a file attachment" #4250

Merged

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Nov 18, 2019

Summary

UI Automation: Write an automated test using Cypress for "At-mention user autocomplete does not overlap with channel header when drafting a long message containing a file attachment"

Ticket Link

mattermost/mattermost#12263

Related Pull Requests

None

Screenshots

None

…te does not overlap with channel header when drafting a long message containing a file attachment"
@jespino jespino requested a review from a team November 18, 2019 14:42
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 18, 2019
@ghost ghost requested review from alifarooq0 and hahmadia and removed request for a team November 18, 2019 14:42
Copy link
Contributor

@hahmadia hahmadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @larkox. Just have a few minor changes in mind 👍

Copy link
Contributor

@hahmadia hahmadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @larkox . Just have a few minor suggestions in mind 👍

Copy link
Contributor

@hahmadia hahmadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM 👍

@hahmadia hahmadia self-assigned this Nov 20, 2019
@hahmadia hahmadia removed the 2: Dev Review Requires review by a core commiter label Nov 21, 2019
@hahmadia hahmadia assigned saturninoabril and unassigned hahmadia Nov 21, 2019
@saturninoabril saturninoabril added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Nov 26, 2019
@hahmadia hahmadia removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Dec 2, 2019
@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request AutoMerge used by Mattermod to merge PR automatically and removed 3: QA Review Requires review by a QA tester labels Dec 13, 2019
@saturninoabril
Copy link
Member

/update-branch

@saturninoabril saturninoabril merged commit 701316f into mattermost:master Dec 13, 2019
@saturninoabril saturninoabril removed the AutoMerge used by Mattermod to merge PR automatically label Dec 13, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants