This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-20180 Fix search in channel members modal #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display loading screen only on startup. Fixes mattermost/mattermost#13095
hanzei
added
2: Dev Review
amyblais
added
the
CherryPick/Approved
saturninoabril
approved these changes
Nov 19, 2019
saturninoabril
added
QA Review Done
and removed
3: QA Review
hmhealey
approved these changes
Nov 20, 2019
|
/update-branch |
bradjcoughlin
approved these changes
Nov 21, 2019
amyblais
added
4: Reviews Complete
mattermod
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Loading screen was shown on each search and that messed up the input. Fixed by displaying loading screen only on startup.
Ticket Link
https://mattermost.atlassian.net/browse/MM-20180