This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Linting global actions #4227
Merged
Linting global actions #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianunez
added
2: Dev Review
|
@cpanato Not sure why this linting error didn't come up in master but did come up later in the 5.17 branch? 🤔 |
|
@marianunez ~5.17 is not based on master so in master that might be changed and in 5.17 not ~ |
cpanato
approved these changes
Nov 14, 2019
@cpanato It was cherry picked to 5.17 so this failure is happening here: #4226 |
|
/shrugwick |
|
In response to this |
bradjcoughlin
approved these changes
Nov 14, 2019
marianunez
added
Tests/Not Needed
mattermod
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed linting issues in
actions\global_actions_test.jsthat are holding up cherry picks to 5.17 branch due to this ci-lint check errorFailing cherry pick: #4226