Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14452 - When a non-sysadmin tries to navigate to a system console URL, the login screen flashes briefly before redirecting to Town Square #4208

Merged
merged 4 commits into from
Nov 18, 2019
Merged

MM-14452 - When a non-sysadmin tries to navigate to a system console URL, the login screen flashes briefly before redirecting to Town Square #4208

merged 4 commits into from
Nov 18, 2019

Conversation

reflog
Copy link
Contributor

@reflog reflog commented Nov 13, 2019

Summary

proper redirect from admin console

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-14452

@reflog reflog added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 13, 2019
@reflog reflog requested review from lindy65 and a team November 13, 2019 15:02
@ghost ghost requested review from bradjcoughlin and streamer45 and removed request for a team November 13, 2019 15:02
streamer45
streamer45 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good! 🎉
Just a couple of strings need updating.

components/admin_console/__snapshots__/admin_console.test.jsx.snap Outdated Show resolved Hide resolved
components/admin_console/admin_console.test.jsx Outdated Show resolved Hide resolved
@lindy65 lindy65 added Setup Cloud Test Server Setup a test server using Mattermost Cloud QA Review Done Tests/Not Needed Does not require new release tests and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Nov 14, 2019
@mattermod
Copy link
Contributor

Test server destroyed

@lindy65 lindy65 added this to the v5.18.0 milestone Nov 14, 2019
lindy65
lindy65 approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reflog 👍 looks good to me!

@reflog reflog requested review from a team and removed request for bradjcoughlin November 18, 2019 09:18
@ghost ghost requested review from iomodo and levb and removed request for a team November 18, 2019 09:18
@reflog reflog removed the request for review from levb November 18, 2019 09:18
iomodo
iomodo approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 18, 2019
@reflog reflog merged commit 81d6ee7 into mattermost:master Nov 18, 2019
@reflog reflog deleted the MM-14452 branch November 18, 2019 14:19
@mattermost-build mattermost-build mentioned this pull request Nov 18, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 18, 2019
reflog added a commit that referenced this pull request Nov 18, 2019
@mattermost-build @reflog
Automated cherry pick of #4208 (#4249)
96114ca 
* proper redirect from admin console

* test

* test name


Co-authored-by: Eli Yukelzon <[email protected]>
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation and removed 2: Dev Review Requires review by a core commiter labels Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@streamer45 streamer45 streamer45 approved these changes

@iomodo iomodo iomodo approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.18.0
6 participants
@reflog @mattermod @streamer45 @iomodo @lindy65 @amyblais