Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-17943 : Add tests for openGroupChannelToUserIds action #4199

Merged
merged 1 commit into from
Nov 14, 2019
Merged

MM-17943 : Add tests for openGroupChannelToUserIds action #4199

merged 1 commit into from
Nov 14, 2019

Conversation

allenl7
Copy link
Contributor

@allenl7 allenl7 commented Nov 12, 2019

Summary

Added jest unit test

Ticket Link

https://mattermost.atlassian.net/browse/MM-17943

Related Pull Requests

  • Has server changes (please link here)
  • Has redux changes (please link here)
  • Has mobile changes (please link here)

Screenshots

@jespino jespino requested a review from a team November 12, 2019 18:00
@ghost ghost requested review from catalintomai and saturninoabril and removed request for a team November 12, 2019 18:00
@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 12, 2019
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@saturninoabril saturninoabril added this to the v5.18.0 milestone Nov 13, 2019
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srkgupta srkgupta added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Nov 13, 2019
@allenl7
Copy link
Contributor Author

allenl7 commented Nov 14, 2019

who will merge this?

@saturninoabril
Copy link
Member

Any of the approvers but I could do that, thanks for following up.

@saturninoabril saturninoabril merged commit 2115f1d into mattermost:master Nov 14, 2019
@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 14, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
6 participants