This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-18708 Fix state of embed visibility for users logging in on same browser/client #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
added
2: Dev Review
srkgupta
added
the
Setup Cloud Test Server
srkgupta
added
QA Review Done
and removed
3: QA Review
|
Test server destroyed |
hmhealey
approved these changes
Nov 12, 2019
saturninoabril
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found this bug by @larkox while submitting E2E for link preview which includes tests for:
...
4. Have the user who posted it click the collapse arrows to collapse the preview
5. Verify preview did not collapse for other user
...
This can probably affect those users who shares logging in to a common workstation.
Before, the storage key is
...:isVisible_[postId]:After,
...:isVisible_[userId]_[postId]:Note: I didn't bother to add backwards compatibility since this don't have noticeable change (where user mostly cared on embed visibility of recent post/s).
Ticket Link
Jira ticket: MM-18708