This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-18677 UI Automation: Clicking on airplane icon does not open file attachment modal but sends the message #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
changed the title
saturninoabril
suggested changes
Nov 11, 2019
e2e/cypress/integration/messaging/message_by_aeroplane_icon_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/messaging/message_by_aeroplane_icon_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/messaging/message_by_aeroplane_icon_spec.js
Outdated
Show resolved
Hide resolved
saturninoabril
added
2: Dev Review
…ec.js Co-Authored-By: Saturnino Abril <[email protected]>
…ec.js Co-Authored-By: Saturnino Abril <[email protected]>
saturninoabril
approved these changes
Nov 11, 2019
lindy65
added
QA Review Done
Tests/Not Needed
deanwhillier
approved these changes
Nov 11, 2019
deanwhillier
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a unit test for sending a message in mobile view with the aeroplane icon. Tests for if message sends and if the file attachment modal does not pop up.
Ticket Link
https://mattermost.atlassian.net/browse/MM-18677
mattermost/mattermost#12267
Related Pull Requests
Screenshots