This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Mobile web: Add aria-labels to navbar buttons #13010 #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/check-cla |
bradjcoughlin
approved these changes
Nov 11, 2019
|
/check-cla |
hmhealey
suggested changes
Nov 12, 2019
There was a problem hiding this comment.
Thanks for the PR, @MathewtheCoder! One small thing that was missed is that these labels should be translatable. You can do that by using the localizeMessage(messageId, defaultMessage) function from utils/utils.jsx to translate the string. You'll also need to add the string to i18n/en.json so that it can be picked up by our translation software
components/channel_header_mobile/channel_info_button/channel_info_button.js
Outdated
Show resolved
Hide resolved
components/channel_header_mobile/show_search_button/show_search_button.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@MathewtheCoder I'm good with the changes, except for the comment on translation.
Ping me once updated, thanks
|
@saturninoabril @hmhealey I have done the translations as requested. |
hmhealey
approved these changes
Nov 14, 2019
saturninoabril
approved these changes
Nov 14, 2019
|
Will try to auto merge this PR |
|
Pull Request successfully merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added aria-label to both info button and search button in mobile web view.
Ticket Link
Fixes mattermost/mattermost#13010
JIRA: https://mattermost.atlassian.net/browse/MM-19752