This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-19909 Fix for scroll pop with markdown images #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
sudheerDev
added
2: Dev Review
* There was a change with inherited classes mattermost#3639 on markdown-inline-img causing this issue * Changing svg place holder to inherit width
|
@deanwhillier About the other changes discussed. I will be making another PR to master as we don't need them to be in 5.17v |
alifarooq0
approved these changes
Nov 8, 2019
deanwhillier
added
the
Setup Cloud Test Server
jgilliam17
added
QA Review Done
and removed
3: QA Review
deanwhillier
approved these changes
Nov 11, 2019
deanwhillier
added
4: Reviews Complete
|
Test server destroyed |
mattermod
added
CherryPick/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a change with inherited classes [MM-12898] Allow in-line markdown images to open preview window #3639 on . markdown-inline-img causing this issue
The change of .markdown-inline-img was added to div intentionally to apply for div wrapper to match the styles of img which is going to be replaced when it loads. Reverted the change
Changing the width of svg to inherit to occupy the space as needed. This wasnt needed earlier but some of the recent changes made this a requirement.
Ticket Link
https://mattermost.atlassian.net/browse/MM-19909