Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-19858] Adding an email address to a post directly doesn't add a target="blank" attribute to the resulting anchor tag. #4162

Merged
merged 3 commits into from
Nov 12, 2019
Merged

[MM-19858] Adding an email address to a post directly doesn't add a target="blank" attribute to the resulting anchor tag. #4162

merged 3 commits into from
Nov 12, 2019

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Nov 7, 2019

Summary

  • Added the proper attribute tags when we parse an email address.

Ticket Link

@cpoile cpoile added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 7, 2019
@cpoile cpoile added this to the v5.17.0 milestone Nov 7, 2019
@cpoile cpoile added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 7, 2019
deanwhillier
deanwhillier approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@deanwhillier deanwhillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Nov 8, 2019
@DHaussermann DHaussermann added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 12, 2019
DHaussermann
DHaussermann approved these changes Nov 12, 2019
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed.

  • Confirmed that email link not wrapped in markdown opens normally from desktop
  • Regression tested email in markdown and in browser
  • Regression tested non-email hypelinks
    LGTM!

@DHaussermann DHaussermann removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Nov 12, 2019
@mattermod
Copy link
Contributor

Test server destroyed

@DHaussermann
Copy link

@deanwhillier or @cpoile please proceed with merge and cherry-pick

@cpoile cpoile merged commit 561c375 into mattermost:master Nov 12, 2019
@cpoile cpoile deleted the MM-19858 branch November 12, 2019 20:35
@mattermost-build mattermost-build mentioned this pull request Nov 12, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 12, 2019
amyblais pushed a commit that referenced this pull request Nov 13, 2019
@mattermost-build @amyblais
Automated cherry pick of #4162 (#4200)
035b019 
* include target="_blank" and rel="noreferrer" to email links for desktop

* tests
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deanwhillier deanwhillier deanwhillier approved these changes

@hmhealey hmhealey hmhealey approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.17.0
6 participants
@cpoile @mattermod @DHaussermann @deanwhillier @hmhealey @amyblais