This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Upgrade Cypress and other E2E dependencies #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
added
2: Dev Review
prapti
approved these changes
Nov 8, 2019
|
@saturninoabril one snapshot testing need to be updated to match the code changes, but otherwise looks good to me. |
jespino
added
4: Reviews Complete
srkgupta
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Hi @saturninoabril
Great work. Everything is looking good except the failing test. Approving the PR.
srkgupta
added
QA Review Done
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
none