Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-19944 - Revert SearchResults to bind search text to SearchResultsTerms #4159

Merged
merged 2 commits into from
Nov 11, 2019
Merged

MM-19944 - Revert SearchResults to bind search text to SearchResultsTerms #4159

merged 2 commits into from
Nov 11, 2019

Conversation

marianunez
Copy link
Member

Summary

Reverted SearchResults component to bind the search bar text to SearchResultsTerms instead of SearchTerms to fix the associated highlight in search bug. This was introduced by #4031

Also, properly cleared the SearchResultsTerms when the RHS is opened to properly fix the original intention on the above change.

Ticket Link

Fixes MM-19944

@marianunez marianunez added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 7, 2019
@marianunez marianunez added this to the v5.17.0 milestone Nov 7, 2019
@marianunez marianunez added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 7, 2019
@crspeller crspeller removed the 2: Dev Review Requires review by a core commiter label Nov 8, 2019
saturninoabril
saturninoabril approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed.

Non-blocking: This is a good candidate to have E2E included. (Anyway, I can submit in separate PR).

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed 3: QA Review Requires review by a QA tester labels Nov 11, 2019
@saturninoabril
Copy link
Member

@marianunez Sorry for the delay. Please update, then good to merge.

@marianunez marianunez merged commit d347857 into master Nov 11, 2019
@marianunez marianunez deleted the MM-19944 branch November 11, 2019 16:01
@mattermost-build mattermost-build mentioned this pull request Nov 11, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 11, 2019
marianunez pushed a commit that referenced this pull request Nov 11, 2019
@mattermost-build @marianunez
Automated cherry pick of #4159 (#4181)
23ac8dc
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 11, 2019
@ogi-m ogi-m added Tests/Not Needed Does not require new release tests Tests/Done Release tests have been written and removed Tests/Not Needed Does not require new release tests labels Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crspeller crspeller crspeller approved these changes

@hmhealey hmhealey hmhealey approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.17.0
7 participants
@marianunez @saturninoabril @crspeller @hmhealey @ogi-m @mattermod @amyblais