This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[GH-12291] UI Automation: Write an automated test using Cypress for "Markdown quotation paragraphs" #4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Fork
Merge fork with Master
Merge Fork into Master
Merge Fork
hanzei
added
2: Dev Review
lindy65
approved these changes
Nov 11, 2019
lindy65
added
QA Review Done
Tests/Not Needed
saturninoabril
suggested changes
Nov 11, 2019
e2e/cypress/integration/messaging/markdown_quotation_paragraphs_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/messaging/markdown_quotation_paragraphs_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/messaging/markdown_quotation_paragraphs_spec.js
Outdated
Show resolved
Hide resolved
Comment on lines
23
to
30
| cy.get('#post_textbox').clear().type('>' + messageParts[0]); | ||
| cy.get('#post_textbox').type('{shift}{enter}{enter}'); | ||
|
|
||
| cy.get('#post_textbox').type('>' + messageParts[1]); | ||
| cy.get('#post_textbox').type('{shift}{enter}{enter}'); | ||
|
|
||
| cy.get('#post_textbox').type('>' + messageParts[2]); | ||
| cy.get('#post_textbox').type('{enter}'); |
There was a problem hiding this comment.
Last request and I'm all good to merge. Please change to
cy.get('#post_textbox').clear().
type('>' + messageParts[0]).type('{shift}{enter}{enter}').
type('>' + messageParts[1]).type('{shift}{enter}{enter}').
type('>' + messageParts[2]).type('{enter}');| // # Post message to use | ||
| cy.get('#post_textbox').clear().type('>' + messageParts[0]).type('{shift}{enter}{enter}'); | ||
| cy.get('#post_textbox').type('>' + messageParts[1]).type('{shift}{enter}{enter}'); | ||
| cy.get('#post_textbox').type('>' + messageParts[2]).type('{enter}'); |
There was a problem hiding this comment.
I'm good with this as is but would be nice to access cy.get('#post_textbox') once, and chain others as necessary.
saturninoabril
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UI Automation: Write an automated test using Cypress for "Markdown quotation paragraphs"
Ticket Link
Fixes mattermost/mattermost#12291
Related Pull Requests
None
Screenshots
None