Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-19862 - Updating post error css RHS #4154

Merged
merged 1 commit into from
Nov 12, 2019
Merged

MM-19862 - Updating post error css RHS #4154

merged 1 commit into from
Nov 12, 2019

Conversation

asaadmahmood
Copy link
Contributor

Summary

MM-19862 - Updating post error css RHS

Ticket Link

https://mattermost.atlassian.net/browse/MM-19862

Screenshots

localhost_8065_bubbles_channels_off-topic
localhost_8065_bubbles_channels_off-topic (1)

Mobile
localhost_8065_bubbles_channels_off-topic(iPhone 6_7_8)

@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 7, 2019
@asaadmahmood asaadmahmood added this to the v5.18.0 milestone Nov 7, 2019
@prapti prapti added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Nov 7, 2019
@mattermod
Copy link
Contributor

Creating a new SpinWick test server using Mattermost Cloud.

@mattermod
Copy link
Contributor

Mattermost test server created! 🎉

Access here: https://mattermost-webapp-pr-4154.test.mattermost.cloud

Account Type Username Password
Admin sysadmin Sys@dmin123
User user-1 User-1@123

sudheerDev
sudheerDev approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@sudheerDev sudheerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinbinnie devinbinnie removed the 2: Dev Review Requires review by a core commiter label Nov 11, 2019
@mattermod
Copy link
Contributor

New commit detected. SpinWick will upgrade if the updated docker image is available.

@mattermod
Copy link
Contributor

Mattermost test server updated with git commit 9a0161f892d7c54ae9563f6781d4416df95913d6.

Access here: https://mattermost-webapp-pr-4154.test.mattermost.cloud

@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Nov 12, 2019
@asaadmahmood asaadmahmood merged commit ef7ae4e into mattermost:master Nov 12, 2019
@asaadmahmood asaadmahmood deleted the MM-19862 branch November 12, 2019 00:54
@mattermod
Copy link
Contributor

@asaadmahmood
Error trying doing the automated Cherry picking. Please do this manually

+++ Updating remotes...
Fetching upstream
Fetching origin
+++ Updating remotes done...
!!! 'upstream/release-5.18' not found. The second argument should be something like upstream/release-0.21.
    (In particular, it needs to be a valid, existing remote branch that I can 'git checkout'.)

@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prapti prapti prapti approved these changes

@sudheerDev sudheerDev sudheerDev approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.18.0
Development

Successfully merging this pull request may close these issues.
6 participants
@asaadmahmood @mattermod @prapti @sudheerDev @devinbinnie @amyblais