[GH-12304] UI Automation: Write an automated test using Cypress for "Compact view: Markdown quotation" #4151
Conversation
Updating Fork
Merge fork with Master
Merge Fork into Master
Merge Fork
…w: Markdown quotation"
saturninoabril
added
2: Dev Review
| const blockQuoteRect = quoteElement[0].getBoundingClientRect(); | ||
|
|
||
| // * We check the username rect does not collide with the quote rect | ||
| expect(userRect.right < blockQuoteRect.left || userRect.bottom < blockQuoteRect.top).to.equal(true); |
There was a problem hiding this comment.
Not sure why we need to verify the second condition as it would not be true (as shown in this screenshot).
userRect.bottom < blockQuoteRect.top
There was a problem hiding this comment.
We are checking whether the username is left to the blockquote, or over it. The userRect.bottom < blockQuoteRect.top part is to check whether is over it. The problem is that, as you mentioned on your second comment, I am not accessing properly the username when it is in compact view. I will fix it and check the two options:
- When the username is to the left (first message after the other person talked)
- When the username is on top (second (or any other) message)
How does that sound?
There was a problem hiding this comment.
On commit 09b252a I did this solution. Please let me know if you think it is enough, or should I check other cases.
There was a problem hiding this comment.
Thanks @larkox. Great work so far.
One more observation:
If we re-run the test case, the user's name is not displayed in the compact view and as a result, the coordinates of userRect is always 0 (as shown in this screenshot). So to overcome this, can you add a step to either post a message as sysadmin to this DM channel (before posting the message as user-1). This way, even in the compact view, when user-1 posts a message, their name is always displayed.
…o the left and username on top
|
Thank you for your contribution @larkox ! 🎉 |
amyblais
added
Changelog/Not Needed
Summary
UI Automation: Write an automated test using Cypress for "Compact view: Markdown quotation"
Ticket Link
mattermost/mattermost#12304
Related Pull Requests
None
Screenshots
None