Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Update storybookUrl to easily override for daily E2E #4144

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Update storybookUrl to easily override for daily E2E #4144

merged 1 commit into from
Nov 8, 2019

Conversation

saturninoabril
Copy link
Member

Summary

Update storybookUrl to easily override with the one being published at https://alpha-storybook.devops.mattermost.com/master/index.html

Ref: https://github.com/mattermost/mattermost-shared-pipelines/pull/39

Ticket Link

Jira ticket: MM-19657

@saturninoabril saturninoabril added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 6, 2019
@saturninoabril saturninoabril added this to the v5.18.0 milestone Nov 6, 2019
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 8, 2019
@srkgupta srkgupta merged commit a2ab2c1 into mattermost:master Nov 8, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 8, 2019
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
@saturninoabril saturninoabril deleted the MM-19657-1 branch November 11, 2019 06:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
5 participants