Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Building properly the notification level string #4143

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Building properly the notification level string #4143

merged 4 commits into from
Nov 19, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Nov 6, 2019

Summary

Building properly the notification level string

Ticket Link

MM-16771

Screenshots

@jespino jespino requested a review from a team November 7, 2019 08:40
@ghost ghost requested review from gigawhitlocks and mickmister and removed request for a team November 7, 2019 08:40
@jespino jespino added the 2: Dev Review Requires review by a core commiter label Nov 7, 2019
@jespino jespino added this to the v5.18.0 milestone Nov 7, 2019
@jespino jespino added the 3: QA Review Requires review by a QA tester label Nov 7, 2019
@jespino jespino requested a review from lindy65 November 7, 2019 08:40
lindy65
lindy65 approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jespino - QA will test this post-merge 👍

@lindy65 lindy65 added QA Review Done Tests/Not Needed Does not require new release tests and removed 2: Dev Review Requires review by a core commiter labels Nov 7, 2019
@jespino jespino added 2: Dev Review Requires review by a core commiter and removed 3: QA Review Requires review by a QA tester labels Nov 7, 2019
@gigawhitlocks gigawhitlocks removed their request for review November 16, 2019 00:28
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 18, 2019
@jespino
Copy link
Member Author

jespino commented Nov 19, 2019

/update-branch

@mgdelacroix mgdelacroix added 4: Reviews Complete All reviewers have approved the pull request AutoMerge used by Mattermod to merge PR automatically and removed 2: Dev Review Requires review by a core commiter AutoMerge used by Mattermod to merge PR automatically labels Nov 19, 2019
@mgdelacroix mgdelacroix merged commit 02a8c58 into mattermost:master Nov 19, 2019
@mattermost-build mattermost-build mentioned this pull request Nov 19, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 19, 2019
jespino pushed a commit that referenced this pull request Nov 19, 2019
@mattermost-build @jespino
Automated cherry pick of #4143 (#4265)
c5c5bc2 
* Building properly the notification level string

* Updating snapshot
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@mickmister mickmister mickmister approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.18.0
6 participants
@jespino @mgdelacroix @mickmister @lindy65 @mattermod @amyblais