Add full screen modal focus trap #4140
Conversation
|
Test server destroyed |
|
Removing the Cloud Test Server. Will need to confirm the scope of this PR with PM. Will pick it up once its confirmed. |
|
/update-branch |
|
Test server destroyed |
There was a problem hiding this comment.
Hi @jespino
Following issues are still seen. Can you please check and fix them:
2. When the Invite People Modal is opened, it should be announced like any other dialogs (Manage Channels or Manage Team Members). Currently the JAWS reader reads "Left Bracket Object Object Right Bracket modal dialog when this is opened.
3. F6 or Ctrl+F6 still does not works on the Invite People modal. Currently it reads out the elements in the background of the modal. F6 or Ctrl+F6 should work like TAB in case of this modal.
|
@srkgupta I have fixed the point 2, the point 3 I have no idea how it works, probably we should defer it to @devinbinnie or @deanwhillier, I took a look of the previous F6 related changes, and I didn't found how to apply that to my PR, I think is not trivial and have relation with sections. |
|
Mattermost test server updated with git commit Access here: https://mattermost-webapp-pr-4140.test.mattermost.cloud |
There was a problem hiding this comment.
Thanks @jespino. Added all the remaining issues in the following ticket.
https://mattermost.atlassian.net/browse/MM-17534
Approving the PR. Testcase added to the release spreadsheet.
|
Test server destroyed |
|
@jespino Some checks are unsuccessful. Can you please check, resolve and merge the PR. |
Summary
Add full screen modal focus trap
Ticket Link
MM-17534