Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Adding aria label to the invite link input #4137

Merged
merged 5 commits into from
Nov 13, 2019
Merged

Adding aria label to the invite link input #4137

merged 5 commits into from
Nov 13, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Nov 5, 2019

Summary

Adding aria label to the invite link input

Ticket Link

MM-17535

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 5, 2019
@jespino jespino added this to the v5.18.0 milestone Nov 5, 2019
lindy65
lindy65 approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jespino 👍

@lindy65 lindy65 added QA Review Done Tests/Not Needed Does not require new release tests and removed 3: QA Review Requires review by a QA tester labels Nov 6, 2019
devinbinnie
devinbinnie approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jespino
Copy link
Member Author

jespino commented Nov 12, 2019

@deanwhillier modified to use the react-intl correct approach

deanwhillier
deanwhillier approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@deanwhillier deanwhillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@deanwhillier deanwhillier added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 13, 2019
@deanwhillier deanwhillier merged commit 348038e into mattermost:master Nov 13, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deanwhillier deanwhillier deanwhillier approved these changes

@lindy65 lindy65 lindy65 approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.18.0
5 participants
@jespino @deanwhillier @lindy65 @devinbinnie @amyblais