This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-19142 - Update webapp dependencies #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing fork up to date
reflog
added
2: Dev Review
|
@reflog looks like something is wrong with the sass builder |
hanzei
approved these changes
Nov 5, 2019
| "@typescript-eslint/parser": "1.13.0", | ||
| "@types/react-router-dom": "5.1.2", | ||
| "@types/react-transition-group": "4.2.3", | ||
| "@typescript-eslint/parser": "2.6.0", |
There was a problem hiding this comment.
Should these types be listed as devDependencies instead so that during production installation, those will not be installed?
There was a problem hiding this comment.
@saturninoabril - good idea. done
saturninoabril
approved these changes
Nov 5, 2019
saturninoabril
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
brewsterbhg
pushed a commit
to brewsterbhg/mattermost-webapp
that referenced
this pull request
Nov 11, 2019
* Fist pass on upgrading packages * Second pass * Second pass * snapshots * fixes eslint errors * sass loader fix, tsc fix * storybook fix, removed redundand test - it's handled by typescript * silly lint * reorg dependencies
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated non-breaking dependencies
Ticket Link
https://mattermost.atlassian.net/browse/MM-19142