Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fix storybook for master branch #4123

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Nov 4, 2019

Summary

Before this PR the master branch was generating it in a weird way so wasn't
able to be visible, with this at least is visibile in the path with "/master",
probably we would need a redirect somehow at root directory.

@jespino jespino added 2: Dev Review Requires review by a core commiter Tests/Not Needed Does not require new release tests labels Nov 4, 2019
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jespino jespino removed the request for review from cpanato November 6, 2019 10:18
@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 6, 2019
@jespino jespino merged commit e0d18ef into mattermost:master Nov 6, 2019
@jespino jespino deleted the build-master-storybook branch November 6, 2019 10:18
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 6, 2019
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
4 participants