Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixed few flaky tests #4121

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Fixed few flaky tests #4121

merged 2 commits into from
Nov 5, 2019

Conversation

srkgupta
Copy link
Contributor

@srkgupta srkgupta commented Nov 4, 2019

Summary

Fixes few Flaky E2E Tests.

  • For some reasons, Cypress was not able to detect the id channelHeaderDropdownMenu even though it was present. I changed it to verify if one of the child elements of the Channel Header Dropdown Menu is present.
  • Instead of Someone removed you, it is expected now to display which user removed. So updated it to sysadmin removed you.
  • Added a small timeout to wait before the channel is created and is displayed.

Ticket Link

NA

@srkgupta srkgupta added the 2: Dev Review Requires review by a core commiter label Nov 4, 2019
@srkgupta
Copy link
Contributor Author

srkgupta commented Nov 4, 2019

Please note that the guest_removal test still fails because of this bug which was reopened recently.
https://mattermost.atlassian.net/browse/MM-19169

prapti
prapti approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed 2: Dev Review Requires review by a core commiter labels Nov 5, 2019
@saturninoabril saturninoabril added this to the v5.18.0 milestone Nov 5, 2019
@saturninoabril saturninoabril merged commit 5f4c583 into mattermost:master Nov 5, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 5, 2019
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
@srkgupta @brewsterbhg
Fixed few flaky tests (mattermost#4121)
b299604 
* Fixed few flaky tests

* Removed extra line.
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation and removed Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prapti prapti prapti approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.18.0
4 participants
@srkgupta @prapti @saturninoabril @amyblais