Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-18582 Remove utils.displayTime in favour of FormattedTime component #4117

Merged
merged 1 commit into from
Nov 6, 2019
Merged

MM-18582 Remove utils.displayTime in favour of FormattedTime component #4117

merged 1 commit into from
Nov 6, 2019

Conversation

niklabh
Copy link
Contributor

@niklabh niklabh commented Nov 3, 2019 •
edited by hanzei
Loading

Summary

Remove utils.displayTime in favour of FormattedTime component

Ticket Link

Fixes mattermost/mattermost#12242

@niklabh niklabh mentioned this pull request Nov 3, 2019
Closed
@hanzei hanzei added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 4, 2019
hmhealey
hmhealey approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

saturninoabril
saturninoabril approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Thanks @niklabh!

@saturninoabril saturninoabril added this to the v5.18.0 milestone Nov 6, 2019
@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request QA Review Done and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 6, 2019
@saturninoabril saturninoabril merged commit 45b4619 into mattermost:master Nov 6, 2019
@saturninoabril saturninoabril changed the title Remove utils.displayTime in favour of FormattedTime component MM-18582 Remove utils.displayTime in favour of FormattedTime component Nov 6, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 6, 2019
@hanzei hanzei deleted the utils-display-time branch November 6, 2019 20:10
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
@niklabh @brewsterbhg
Remove utils.displayTime in favour of FormattedTime component (matter…
a52aa5e 
…most#4117)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Willyfrog Willyfrog Willyfrog approved these changes

@hmhealey hmhealey hmhealey approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.18.0
6 participants
@niklabh @Willyfrog @hmhealey @saturninoabril @hanzei @amyblais