Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[GH-12993] Migrate 'components/admin_console/setting.jsx' and associated tests to TypeScript #4114

Merged
merged 6 commits into from
Nov 4, 2019

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Nov 2, 2019

Summary

Migrate 'components/admin_console/setting.jsx' and associated tests to TypeScript

Ticket Link

mattermost/mattermost#12993

Related Pull Requests

None

Screenshots

None

@jespino jespino added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 2, 2019
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @larkox! 🎉

Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwilander jwilander merged commit 02f0c6b into mattermost:master Nov 4, 2019
@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Nov 4, 2019
@jwilander jwilander removed the request for review from saturninoabril November 4, 2019 13:51
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 4, 2019
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
…ted tests to TypeScript (mattermost#4114)

* Update references to Setting.jsx

* Migrate 'components/admin_console/setting.jsx' to Typescript
@lindy65 lindy65 added the Tests/Not Needed Does not require new release tests label Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
5 participants