This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-19844 - Disallow plugin upload when PluginSettings.RequirePluginSignature is true #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnature is true
alifarooq0
added
1: PM Review
marianunez
suggested changes
Nov 1, 2019
i18n/en.json
Outdated
| @@ -1140,6 +1140,8 @@ | |||
| "admin.plugins.settings.marketplaceUrl": "Marketplace URL:", | |||
| "admin.plugins.settings.marketplaceUrlDesc": "URL of the marketplace server.", | |||
| "admin.plugins.settings.marketplaceUrlDesc.empty": " Marketplace URL is a required field.", | |||
| "admin.plugins.settings.requirePluginSignature": "Require Plugin Signature:", | |||
| "admin.plugins.settings.requirePluginSignatureDesc": "When true, uploading plugins is disabled and plugins are always verified during Mattermost server startup and initialization.", | |||
There was a problem hiding this comment.
If we say that uploading is disabled then we should include how they can still install plugins through marketplace which may not be that obvious if not familiar.
Maybe something like:
"When true, plugins signatures are verified at installation and server startup. Additionally, plugins may only be installed through the Plugins Marketplace and manual uploading plugins is disabled."
0/5 on exact wording.
There was a problem hiding this comment.
Left the link as a generic link for now. Will update when @justinegeffen finalizes the doc.
aaronrothschild
approved these changes
Nov 1, 2019
aaronrothschild
added
Docs/Needed
iomodo
approved these changes
Nov 1, 2019
marianunez
approved these changes
Nov 2, 2019
marianunez
added
3: QA Review
|
@prapti FYI - merging this into the feature branch. Plan to have this tested when feature goes into |
lieut-data
pushed a commit
that referenced
this pull request
Nov 19, 2019
* MM-18797 - Switch webapp to use '/plugins/marketplace' API to install… (#3871) * MM-18797 - Switch webapp to use '/plugins/marketplace' API to install marketplace plugins * Updated tests * Removing ui marketplace install event * Revert "Removing ui marketplace install event" This reverts commit 5419ce0. * Updating redux dependency * MM-19844 - Disallow plugin upload when PluginSettings.RequirePl… (#4109) * MM-19844 - Disallow plugin upload when PluginSettings.RequirePluginSignature is true * Fixed text * Fixed snapshot * Fixing snapshot * Bumping redux ver * temp redux commit * update snapshots re: i18n * Bumping redux ver
lieut-data
pushed a commit
that referenced
this pull request
Nov 19, 2019
* MM-18797 - Switch webapp to use '/plugins/marketplace' API to install… (#3871) * MM-18797 - Switch webapp to use '/plugins/marketplace' API to install marketplace plugins * Updated tests * Removing ui marketplace install event * Revert "Removing ui marketplace install event" This reverts commit 5419ce0. * Updating redux dependency * MM-19844 - Disallow plugin upload when PluginSettings.RequirePl… (#4109) * MM-19844 - Disallow plugin upload when PluginSettings.RequirePluginSignature is true * Fixed text * Fixed snapshot * Fixing snapshot * Bumping redux ver * temp redux commit * update snapshots re: i18n * Bumping redux ver
|
@ali-farooq0 Added a note to docs about this functionality. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
RequirePluginSignaturesetting to plugin configuration page.Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-19844
Screenshots
When
RequirePluginSignatureistrueWhen
RequirePluginSignatureisfalse