Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-18373 - Updating suggestion list for Firefox #4087

Merged
merged 1 commit into from
Oct 31, 2019
Merged

MM-18373 - Updating suggestion list for Firefox #4087

merged 1 commit into from
Oct 31, 2019

Conversation

asaadmahmood
Copy link
Contributor

@asaadmahmood asaadmahmood commented Oct 30, 2019 •
edited
Loading

Summary

MM-18373 - Updating suggestion list for Firefox
The previous configuration was not working for Rohit, so just reverted back the change to say "alert + [username]" for the suggestion list.

Ticket Link

https://mattermost.atlassian.net/browse/MM-18373

@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 30, 2019
@asaadmahmood asaadmahmood added this to the v5.17.0 milestone Oct 30, 2019
@srkgupta srkgupta added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Oct 30, 2019
srkgupta
srkgupta approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the PR instance and the changes were reverted.

@srkgupta srkgupta added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Oct 31, 2019
@mattermod
Copy link
Contributor

Test server destroyed

@asaadmahmood asaadmahmood requested review from devinbinnie and enahum and removed request for hmhealey and bradjcoughlin October 31, 2019 17:26
@asaadmahmood asaadmahmood requested review from bradjcoughlin and removed request for enahum October 31, 2019 18:07
bradjcoughlin
bradjcoughlin approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@bradjcoughlin bradjcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asaadmahmood asaadmahmood merged commit 540a281 into mattermost:master Oct 31, 2019
@asaadmahmood asaadmahmood deleted the MM-18373 branch October 31, 2019 18:09
@mattermost-build mattermost-build mentioned this pull request Oct 31, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 31, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation and removed 2: Dev Review Requires review by a core commiter labels Oct 31, 2019
brewsterbhg pushed a commit to brewsterbhg/mattermost-webapp that referenced this pull request Nov 11, 2019
@asaadmahmood @brewsterbhg
MM-18373 - Updating suggestion list for firefox (mattermost#4087)
a3b207f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@bradjcoughlin bradjcoughlin bradjcoughlin approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@asaadmahmood @mattermod @srkgupta @bradjcoughlin @devinbinnie @amyblais